github-actions[bot] commented on code in PR #28698:
URL: https://github.com/apache/doris/pull/28698#discussion_r1432228834
##########
be/src/vec/sink/vdata_stream_sender.cpp:
##########
@@ -777,18 +775,14 @@ void VDataStreamSender::_roll_pb_block() {
_cur_pb_block = (_cur_pb_block == &_pb_block1 ? &_pb_block2 : &_pb_block1);
}
-Status VDataStreamSender::_get_next_available_buffer(BroadcastPBlockHolder**
holder) {
- if (_broadcast_pb_block_idx >= _broadcast_pb_blocks.size()) {
- return Status::InternalError(
- "get_next_available_buffer meet invalid index, index={},
size={}",
- _broadcast_pb_block_idx, _broadcast_pb_blocks.size());
- }
- if (!_broadcast_pb_blocks[_broadcast_pb_block_idx].available()) {
- return Status::InternalError("broadcast_pb_blocks not available");
+Status VDataStreamSender::_get_next_available_buffer(
Review Comment:
warning: method '_get_next_available_buffer' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/vdata_stream_sender.h:160:
```diff
- Status
_get_next_available_buffer(std::shared_ptr<BroadcastPBlockHolder>* holder);
+ static Status
_get_next_available_buffer(std::shared_ptr<BroadcastPBlockHolder>* holder);
```
##########
be/src/pipeline/exec/exchange_sink_buffer.h:
##########
@@ -71,25 +72,51 @@ struct AtomicWrapper {
// We use BroadcastPBlockHolder to hold a broadcasted PBlock. For broadcast
shuffle, one PBlock
// will be shared between different channel, so we have to use a ref count to
mark if this
// PBlock is available for next serialization.
+class BroadcastPBlockHolderQueue;
class BroadcastPBlockHolder {
+ ENABLE_FACTORY_CREATOR(BroadcastPBlockHolder);
+
public:
- BroadcastPBlockHolder() : _ref_count(0), _dep(nullptr) {}
- BroadcastPBlockHolder(pipeline::BroadcastDependency* dep) : _ref_count(0),
_dep(dep) {}
- ~BroadcastPBlockHolder() noexcept = default;
+ BroadcastPBlockHolder() { _pblock = std::make_unique<PBlock>(); }
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```cpp
BroadcastPBlockHolder() { _pblock = std::make_unique<PBlock>(); }
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
