DongLiang-0 commented on code in PR #269:
URL:
https://github.com/apache/doris-flink-connector/pull/269#discussion_r1426397862
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##########
@@ -90,10 +89,12 @@ public void put(Object o) {
private List<FieldVector> fieldVectors;
private RootAllocator rootAllocator;
private final Schema schema;
- private final String DATETIME_PATTERN = "yyyy-MM-dd HH:mm:ss";
- private final String DATETIMEV2_PATTERN = "yyyy-MM-dd HH:mm:ss.SSSSSS";
- private final DateTimeFormatter dateTimeFormatter =
DateTimeFormatter.ofPattern(DATETIME_PATTERN);
- private final DateTimeFormatter dateTimeV2Formatter =
DateTimeFormatter.ofPattern(DATETIMEV2_PATTERN);
+ private final String datetimePattern = "yyyy-MM-dd HH:mm:ss";
+ private final String datetimeV2Pattern = "yyyy-MM-dd HH:mm:ss.SSSSSS";
Review Comment:
Yes, changed!
##########
flink-doris-connector/src/test/java/org/apache/doris/flink/utils/DateToStringConverter.java:
##########
@@ -43,23 +43,27 @@ public class DateToStringConverter implements
CustomConverter<SchemaBuilder, Rel
private DateTimeFormatter timestampFormatter =
DateTimeFormatter.ISO_DATE_TIME;
private ZoneId timestampZoneId = ZoneId.systemDefault();
- public static Properties DEFAULT_PROPS = new Properties();
+ public static Properties defaultProps = new Properties();
Review Comment:
Yes, changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
