JNSimba commented on code in PR #269:
URL:
https://github.com/apache/doris-flink-connector/pull/269#discussion_r1426389555
##########
flink-doris-connector/src/test/java/org/apache/doris/flink/utils/DateToStringConverter.java:
##########
@@ -43,23 +43,27 @@ public class DateToStringConverter implements
CustomConverter<SchemaBuilder, Rel
private DateTimeFormatter timestampFormatter =
DateTimeFormatter.ISO_DATE_TIME;
private ZoneId timestampZoneId = ZoneId.systemDefault();
- public static Properties DEFAULT_PROPS = new Properties();
+ public static Properties defaultProps = new Properties();
Review Comment:
Does it have to be static final to be capitalized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
