weizuo93 commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-doris/pull/5452#discussion_r608307385



##########
File path: be/src/http/action/stream_load.cpp
##########
@@ -533,4 +539,17 @@ Status StreamLoadAction::_data_saved_path(HttpRequest* 
req, std::string* file_pa
     return Status::OK();
 }
 
+void StreamLoadAction::_sava_stream_load_record(StreamLoadContext* ctx, const 
std::string& str) {
+    auto stream_load_recorder = 
StorageEngine::instance()->get_stream_load_recorder();
+    if (stream_load_recorder != nullptr) {
+        std::string key = std::to_string(ctx->start_micros + 
ctx->load_cost_micros) + "_" + ctx->label;
+        auto st = stream_load_recorder->put(key, str);
+        if (st.ok()) {

Review comment:
       > Also need to log when put into rocksdb failed
   
   There is log in `StreamLoadRecorder::put()`when putting data into rocksdb 
failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to