weizuo93 commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-doris/pull/5452#discussion_r607578246



##########
File path: gensrc/thrift/BackendService.thrift
##########
@@ -134,4 +159,6 @@ service BackendService {
     // release the context resource associated with the context_id
     DorisExternalService.TScanCloseResult close_scanner(1: 
DorisExternalService.TScanCloseParams params);
 
+    TStreamLoadRecordResult get_stream_load_record(1: string params);

Review comment:
       > Rename `params` to a meaningful name, maybe `last_record_time`?
   > But I think we'd better use a timestamp (which is in Long Integer type) to 
pass this param to decouple the implementation between RPC interface and the 
implementation in BE.
   
   Thank you. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to