yangzhg edited a comment on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675954087
@imay From the point of view of implementation, our implementation should be copied from leveldb, but leveldb has removed some unnecessary bit operation in this pr https://github.com/google/leveldb/commit/cf1b5f473259e46c667f3fb5a28bcd884ee3a102#diff-0f30ecb01c7888631c52ec595204f7f0 , so I think we can accept this pr and change to the same implementation as level db, although this change improves performance not particularly big ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
