imay commented on pull request #4366: URL: https://github.com/apache/incubator-doris/pull/4366#issuecomment-675370532
> > Not intended to interfere, just curious about how many improvements can be achieved from this PR, are there any benchmarks? > > In my develop computure, when encode_varint64 execute 1 billion times. `v | B` version averagely uses 95095ms in 5 times. > `(v & (B - 1))` version averagely uses 96103ms in 5 times. It can improve aboat 0.5% ～ 1%. Encode_varint64 is used high frequency in many cases like bitmap_value, page_pointer encode and so on. It seems too slow to execute 5 bilion enocde operation in about 95s ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
