yangzhg commented on a change in pull request #4212:
URL: https://github.com/apache/incubator-doris/pull/4212#discussion_r471996935
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -277,6 +281,27 @@ void*
StorageEngine::_disk_stat_monitor_thread_callback(void* arg) {
return nullptr;
}
+void StorageEngine::_check_cumulative_compaction_config() {
+
+ std::string cumulative_compaction_type =
config::cumulative_compaction_policy;
+ boost::to_upper(cumulative_compaction_type);
+
+ // if size_based policy is used, check size_based policy configs
+ if (cumulative_compaction_type == CUMULATIVE_SIZE_BASED_POLICY_TYPE) {
+ int64_t size_based_promotion_size =
+ config::cumulative_compaction_size_based_promotion_size_mbytes;
+ int64_t size_based_promotion_min_size =
+
config::cumulative_compaction_size_based_promotion_min_size_mbytes;
+ int64_t size_based_compaction_lower_bound_size =
+
config::cumulative_compaction_size_based_compaction_lower_bound_size_mbytes;
+
+ // check size_based_promotion_size must be greater than
size_based_promotion_min_size
+ CHECK(size_based_promotion_size >= size_based_promotion_min_size);
Review comment:
It is better to set to min size instead of usingf check here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
