morningman commented on a change in pull request #3647:
URL: https://github.com/apache/incubator-doris/pull/3647#discussion_r428585519
##########
File path:
fe/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
##########
@@ -721,8 +728,12 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) thr
}
if (healthReplicaNum < quorumReplicaNum) {
- LOG.info("publish version failed for
transaction {} on tablet {}, with only {} replicas less than quorum {}",
+ LOG.info("publish version failed for
transaction {} on tablet {}, with only {} replicas less than quorum {}",
transactionState, tablet,
healthReplicaNum, quorumReplicaNum);
+ String errMsg = String.format("publish on
tablet %d failed. succeed replica num %d less than quorum %d."
+ + " table: %d, partition: %d, publish
version: %d",
+ tablet.getId(), healthReplicaNum,
quorumReplicaNum, tableId, partitionId, partition.getVisibleVersion() + 1);
+ transactionState.setErrorMsg(errMsg);
Review comment:
versions before `version` is continuous. `lastSuccessVersion` is the
last success version of this replica. `lastFailedVersion` is the last failed
version of this replica. eg:
versio: 10
lastSuccessVersion:12
lastFailedVersion:11
which means version 0-10 is continuous and success. and version 11 failed to
publish. but
version 12 success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
