xy720 commented on a change in pull request #3647:
URL: https://github.com/apache/incubator-doris/pull/3647#discussion_r428514558
##########
File path:
fe/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
##########
@@ -721,8 +728,12 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) thr
}
if (healthReplicaNum < quorumReplicaNum) {
- LOG.info("publish version failed for
transaction {} on tablet {}, with only {} replicas less than quorum {}",
+ LOG.info("publish version failed for
transaction {} on tablet {}, with only {} replicas less than quorum {}",
transactionState, tablet,
healthReplicaNum, quorumReplicaNum);
+ String errMsg = String.format("publish on
tablet %d failed. succeed replica num %d less than quorum %d."
+ + " table: %d, partition: %d, publish
version: %d",
+ tablet.getId(), healthReplicaNum,
quorumReplicaNum, tableId, partitionId, partition.getVisibleVersion() + 1);
+ transactionState.setErrorMsg(errMsg);
Review comment:
What is the different between version and
lastSuccessVersion/lastFailedVersion? Why only update
lastSuccessVersion/lastFailedVersion but not version when we found replica's
lastFailedVersion is larger than 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
