imay commented on a change in pull request #2235: Support setting properties
for storage_root_path
URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347849961
##########
File path: be/src/olap/options.h
##########
@@ -26,11 +26,14 @@
namespace doris {
struct StorePath {
- StorePath() : capacity_bytes(-1) { }
+ StorePath() : capacity_bytes(-1), storage_medium(TStorageMedium::HDD){ }
Review comment:
The code in Doris comes from many different projects. Generally, the style
of each file is consistent, if you add code to a file, you should keep style
with it. If it is a new file, Baidu's code style is used. It's about the same
style as Google's. Except lowercase and underscore as the function name, and
use 4-byte indentation and so on.
clang-format is a good suggestion, we should introduce it to our project to
make developers easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
