imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347832159
########## File path: be/src/olap/options.h ########## @@ -26,11 +26,14 @@ namespace doris { struct StorePath { - StorePath() : capacity_bytes(-1) { } + StorePath() : capacity_bytes(-1), storage_medium(TStorageMedium::HDD){ } StorePath(const std::string& path_, int64_t capacity_bytes_) : path(path_), capacity_bytes(capacity_bytes_) { } Review comment: missing medium's default value? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org