leerho commented on code in PR #242:
URL:
https://github.com/apache/datasketches-memory/pull/242#discussion_r1876783669
##########
src/test/java/org/apache/datasketches/memory/internal/BufferTest.java:
##########
@@ -60,56 +59,56 @@ public void checkDirectRoundTrip() throws Exception {
public void checkAutoHeapRoundTrip() {
int n = 1024; //longs
WritableBuffer wbuf = WritableMemory.allocate(n * 8).asWritableBuffer();
- for (int i = 0; i < n; i++) {
- wbuf.putLong(i);
- }
- wbuf.resetPosition();
- for (int i = 0; i < n; i++) {
- long v = wbuf.getLong();
- assertEquals(v, i);
+ for (int i = 0; i < n; i++) {
+ wbuf.putLong(i);
+ }
+ wbuf.resetPosition();
+ for (int i = 0; i < n; i++) {
+ long v = wbuf.getLong();
+ assertEquals(v, i);
+ }
}
- }
@Test
public void checkArrayWrap() {
int n = 1024; //longs
byte[] arr = new byte[n * 8];
WritableBuffer wbuf = WritableMemory.writableWrap(arr).asWritableBuffer();
- for (int i = 0; i < n; i++) {
- wbuf.putLong(i);
- }
- wbuf.resetPosition();
- for (int i = 0; i < n; i++) {
- long v = wbuf.getLong();
- assertEquals(v, i);
- }
+ for (int i = 0; i < n; i++) {
Review Comment:
Wow! this is weird. No tabs used. Not sure how this happened. We have had
two folks editing these files recently, perhaps they used a different indention
scheme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
