AlexanderSaydakov commented on code in PR #242:
URL:
https://github.com/apache/datasketches-memory/pull/242#discussion_r1876493792
##########
README.md:
##########
@@ -66,10 +66,12 @@ Note: *primitive* := *{byte, short, int, long, float,
double}*
* *Memory.map(File)* (read only)
* *WritableMemory.writableMap(File)*
-## Release 4.0.0 (inclusive) to 5.0.0 (exclusive)
-Starting with release *datasketches-memory-4.0.0*, this Memory component
supports only Java 17 when compiling from source and should work with later
Java versions at runtime.
+## Release 5.0.0 (inclusive) to 6.0.0 (exclusive)
+Starting with release *datasketches-memory-5.0.0*, this Memory component
supports only Java 21 when compiling from source and should work with later
Java versions at runtime.
-### *NOTE: The DataSketches Java Memory Component is not thread-safe.*
+### *NOTES:*
+* The DataSketches Java Memory Component is not thread-safe.
+* I recommend Eclipse Adoptium/Temurin 21.0.5+11 or later as earlier releases
of 21 have bugs that affect this product.
Review Comment:
first person recommendation looks strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
