rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255496880
########## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ########## @@ -72,7 +71,7 @@ public static PreallocationType getPreallocationType(final Storage.ProvisioningT case FAT: return PreallocationType.Full; default: - throw new NotImplementedException(); + throw new NotImplementedProvisioningTypeException(String.format("type {} not defined as member-value of PreallocationType", provisioningType)); Review comment: Is this a new type of `String.format` use? I am missing a `%s` there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services