rafaelweingartner commented on a change in pull request #3170: NotImplemented
as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255483128
##########
File path:
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
##########
@@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final
Storage.ProvisioningT
case FAT:
return PreallocationType.Full;
default:
- throw new NotImplementedException();
+ throw new NotImplementedProvisioningTypeException();
Review comment:
It also works. I only think that we need to add something in the exception.
I mean, a message saying what is not implemented (the preallocation type
selected/sent by the user).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
