sureshanaparti commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#discussion_r252791444
########## File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java ########## @@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) { return false; } + /** + * True if volumes source storage are NFS + */ Review comment: @nvazquez If multiple volumes are on the same storage is what being checked, why Map with multiple volumes & looping around them is required? it can be extended? any current use case supports this? if extended, it only checks for NFS pool. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services