sureshanaparti commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r252179023
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -253,18 +262,64 @@ private boolean canHandle(DataObject dataObject) {
return false;
}
+ /**
+ * True if volumes source storage are NFS
+ */
+ protected boolean isSourceNfsPrimaryStorage(Map<VolumeInfo, DataStore>
volumeMap) {
+ if (MapUtils.isNotEmpty(volumeMap)) {
+ for (VolumeInfo volumeInfo : volumeMap.keySet()) {
+ StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
+ return storagePoolVO != null &&
+ storagePoolVO.getPoolType() ==
Storage.StoragePoolType.NetworkFilesystem;
+ }
+ }
+ return false;
+ }
+
+ /**
+ * True if destination storage is cluster-wide NFS
Review comment:
Ok. So intent is to validate atleast one cluster wide NFS pool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
