GabrielBrascher opened a new pull request #3154: Copy template to target KVM host if needed when migrating local <> local storage URL: https://github.com/apache/cloudstack/pull/3154 PR #2997 allowed KVM VM live migration with ROOT volume on local storage (filesystem), if the template is already on the target host, the migration will be successful; however, if the VM template is not on the target host the migration fails. This PR fixes the bug introduced by #2997, copying the VM template to the target host if needed. ## Description <!--- Describe your changes in detail --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> - [x] Tested migrating a VM to a host that did not download the template to its primary storage. The added code is then executed, copying the template to the target host/primary storage; after migrating the template, the execution flows keep as it was previously and the migration is succesfull. - [x] Successfully migrated a VM in the case where both storage pools (source and destiny host) have the VM template. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
