rafaelweingartner commented on a change in pull request #3125: IP address
acquired with associate ip address is marked as source nat
URL: https://github.com/apache/cloudstack/pull/3125#discussion_r247356610
##########
File path: server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
##########
@@ -1425,6 +1416,32 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
+ /**
+ * Prevents associating an IP address to an allocated (unimplemented
network) network, throws an Exception otherwise
+ * @param owner Used to check if the user belongs to the Network
+ * @param ipToAssoc IP address to be associated to a Network, can only be
associated to an implemented network for Source NAT
+ * @param network Network to which IP address is to be associated with,
must not be in allocated state for Source NAT Network/IP association
+ * @return true if IP address can be successfully associated with Source
NAT network
+ */
+ protected boolean isSourceNatAvailableForNetwork(Account owner,
IPAddressVO ipToAssoc, Network network) {
+ NetworkOffering offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
+ boolean sharedSourceNat = offering.isSharedSourceNat();
+ boolean isSourceNat = false;
+ if (!sharedSourceNat) {
+ if (getExistingSourceNatInNetwork(owner.getId(), network.getId())
== null) {
+ if (network.getGuestType() == GuestType.Isolated &&
network.getVpcId() == null && !ipToAssoc.isPortable()) {
+ if (network.getState() == Network.State.Allocated) {
+ //prevent associating an ip address to an allocated
(unimplemented network).
+ //it will cause the ip to become source nat, and it
can't be disassociated later on.
+ throw new InvalidParameterValueException("Network is
in allocated state, implement network first before acquiring an IP address");
Review comment:
Ah sure, I do agree with you that logging is not necessary here.
What I meant is that if we add the UUID to the exception description, when
it is logged (I guess the exception will be written to the log at some point),
we will be able to have a better way to identity which network caused the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
