rafaelweingartner commented on a change in pull request #3125: IP address
acquired with associate ip address is marked as source nat
URL: https://github.com/apache/cloudstack/pull/3125#discussion_r247096508
##########
File path: server/src/test/java/com/cloud/network/IpAddressManagerTest.java
##########
@@ -32,28 +35,58 @@
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
+import org.mockito.Spy;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceUnavailableException;
import com.cloud.network.Network.Service;
import com.cloud.network.dao.IPAddressDao;
import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.dao.NetworkDao;
+import com.cloud.network.dao.NetworkVO;
import com.cloud.network.rules.StaticNat;
import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.user.AccountVO;
import com.cloud.utils.net.Ip;
public class IpAddressManagerTest {
@Mock
IPAddressDao _ipAddrDao;
+ @Mock
+ NetworkDao _networkDao;
+
+ @Mock
+ NetworkOfferingDao _networkOfferingDao;
+
+ @Spy
@InjectMocks
IpAddressManagerImpl _ipManager;
@InjectMocks
NetworkModelImpl networkModel = Mockito.spy(new NetworkModelImpl());
+ IPAddressVO ipAddressVO;
+
+ AccountVO account;
+
@Before
- public void setup() {
+ public void setup() throws ResourceUnavailableException {
MockitoAnnotations.initMocks(this);
Review comment:
You should do not need this one. You can annotate the class with a jUnit
runner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
