bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231597922
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String
bridgeName) {
return "";
}
- String [] _ifNamePatterns = {
+ static String [] ifNamePatterns = {
Review comment:
@rafaelweingartner I think it's a good extension, but suppose it's a
conceptual change which requires voting from the project team. Don't you think
so?
Personally, I like your approach, but people "potentially" may meet
incompatibilities in their deployments if they have weird bridging
configurations.
@rhtyd @PaulAngus @DaanHoogland @wido @GabrielBrascher can give your
opinions on such a change, that @rafaelweingartner suggests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
