rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update
role permission
URL: https://github.com/apache/cloudstack/pull/2236#discussion_r132470327
##########
File path:
api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRolePermissionCmd.java
##########
@@ -51,10 +52,16 @@
description = "ID of the role", validations =
{ApiArgValidator.PositiveNumber})
private Long roleId;
- @Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST,
collectionType = CommandType.UUID, required = true, entityType =
RolePermissionResponse.class,
+ @Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST,
collectionType = CommandType.UUID, entityType = RolePermissionResponse.class,
description = "The parent role permission uuid, use 0 to move this
rule at the top of the list")
private List<Long> rulePermissionOrder;
+ @Parameter(name = ApiConstants.RULE_ID, type = CommandType.UUID,
entityType = RolePermissionResponse.class, description = "Role permission rule
id")
Review comment:
@nvazquez This is a new arg, can you add a since field to say '4.11'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
