rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update
role permission
URL: https://github.com/apache/cloudstack/pull/2236#discussion_r132470387
##########
File path:
api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRolePermissionCmd.java
##########
@@ -51,10 +52,16 @@
description = "ID of the role", validations =
{ApiArgValidator.PositiveNumber})
private Long roleId;
- @Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST,
collectionType = CommandType.UUID, required = true, entityType =
RolePermissionResponse.class,
+ @Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST,
collectionType = CommandType.UUID, entityType = RolePermissionResponse.class,
description = "The parent role permission uuid, use 0 to move this
rule at the top of the list")
private List<Long> rulePermissionOrder;
+ @Parameter(name = ApiConstants.RULE_ID, type = CommandType.UUID,
entityType = RolePermissionResponse.class, description = "Role permission rule
id")
+ private Long ruleId;
+
+ @Parameter(name = ApiConstants.PERMISSION, type = CommandType.STRING,
description = "Rule permission, can be: allow or deny")
Review comment:
@nvazquez please add a `since` to 4.11 here as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
