DaanHoogland opened a new pull request, #14554: URL: https://github.com/apache/cloudstack/pull/14554
### Description Removes Hyper-V support from core code now that the Hyper-V plugin is no longer built (see #12500). This is the first PR of a stack on `main`: 1. **this PR**: remove Hyper-V support from core code 2. remove Ovm/Ovm3 leftovers from core code (based on this branch) 3. code-style cleanups (based on 2) The first four commits are #12500 ported to `main`, so this branch builds without the plugins. Once 4.22 is merged forward they become empty. **Behaviour / API changes** - `listTrafficTypes`, `addTrafficType` and `updateTrafficType` responses no longer include `hypervnetworklabel`. The `hypervnetworklabel` request parameter is `@Deprecated` and ignored. - Removed the settings `router.template.hyperv`, `hyperv.public.network.device`, `hyperv.private.network.device` and `hyperv.guest.network.device`. `schema-42300to2400.sql` deletes them, along with `ucs.sync.blade.interval`. - The `hypervisor.list` default no longer contains `Hyperv`. Existing values set by admins are left untouched. - Hyper-V specific branches are removed from HA, live migration, the control NIC, the VR boot args, storage pool and zone-wide pool handling, system VM template registration and the rdpconsole CLI. **Deliberately kept** - `HypervisorType.Hyperv` (now `@Deprecated`). `HypervisorTypeConverter` uses `valueOf()`, which throws on unknown names, and existing installations have `Hyperv` rows (for example the seeded `guest_os_hypervisor` mappings). Removing the constant would make loading those rows fail. - Historic upgrade paths (`Upgrade41500to41510`, `schema-410to420.sql`, `schema-41520to41600.sql`) are unchanged. - The console-proxy RDP path. It keys off the agent's VNC port `-9`, not off the hypervisor type, and the new Hyper-V extension (`extensions/HyperV`) may rely on it. **Possible follow-ups (not in this PR):** UI Hyper-V options, `hyperv_network_label` column and `NetworkService` label parameters, appliance build scripts, marvin test data, `setup/db/templates.sql`. ### Types of changes - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### How Has This Been Tested? Unit tests updated: `ApiResponseHelperTest`, `SystemVmTemplateRegistrationTest`, `SecondaryStorageManagerTest`, `ManagementServerImplTest`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
