DaanHoogland opened a new pull request, #14555: URL: https://github.com/apache/cloudstack/pull/14555
Depends on https://github.com/apache/cloudstack/pull/14554 ### Description Second PR of the stack: removes the Ovm/Ovm3 leftovers from core code. The plugins have not been built since #11196 ("ovm deprecation"). **Based on the Hyper-V removal PR; review only the last commit.** **Behaviour / API changes** - Traffic type responses no longer include `ovm3networklabel`. The `ovm3networklabel` request parameter is `@Deprecated` and ignored. - Removed the settings `router.template.ovm3`, `ovm.{public,private,guest}.network.device`, `ovm3.{public,private,guest,storage}.network.device`, `ovm3.heartbeat.timeout` and `ovm3.heartbeat.interval`. `schema-42300to2400.sql` deletes them. - The `hypervisor.list` default no longer contains `Ovm`/`Ovm3`. `LXC` stays: an earlier version of this change dropped it by mistake. - Ovm/Ovm3 are removed from the live-migration and storage-pool hypervisor lists, the system VM template registration, `templateConfig.sh`, the `download-ovm-systemvm-template` profile and `package.sh`. **Deliberately kept:** `HypervisorType.Ovm`/`Ovm3`, for the same DB-compatibility reason as `Hyperv`. Also kept: historic upgrade paths, and the remaining `Ovm` branches in `VolumeOrchestrator`, `StorageManagerImpl`, `OCFS2ManagerImpl`, `SnapshotManagerImpl` and `ResourceManagerImpl` (possible follow-ups). ### Types of changes - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### How Has This Been Tested? Unit tests updated: `ApiResponseHelperTest`, `SystemVmTemplateRegistrationTest`, `ManagementServerImplTest`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
