Damans227 commented on code in PR #14046:
URL: https://github.com/apache/cloudstack/pull/14046#discussion_r4174926923
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -946,7 +946,7 @@ protected void updateIcmpCodeAndType (boolean
isPartialUpgrade, UpdateNetworkACL
}
private void updateIcmpCodeAndTypeFullUpgrade (Integer icmpCode, Integer
icmpType, NetworkACLItemVO networkACLItemVo) {
- if
(networkACLItemVo.getProtocol().equalsIgnoreCase(NetUtils.ICMP_PROTO)) {
+ if
(NetUtils.ICMP_PROTO.equalsIgnoreCase(networkACLItemVo.getProtocol())) {
Review Comment:
what happens when this rule with no protocol gets pushed to the router?
looks like building the router rules would crash on it instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
