nagaboinaramgopal commented on PR #14046: URL: https://github.com/apache/cloudstack/pull/14046#issuecomment-5957623255
Hi @nvazquez, this touches `updateIcmpCodeAndTypeFullUpgrade`, which you originally wrote, so you'd understand the ICMP handling much better than I would. It fixes an NPE when a rule has no protocol set. Whenever you have a spare moment, would you mind taking a look? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
