Damans227 commented on code in PR #14240:
URL: https://github.com/apache/cloudstack/pull/14240#discussion_r4158309490
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java:
##########
@@ -458,6 +458,14 @@ public boolean isExistingBridge(String bridgeName) {
@Override
public void deleteBr(NicTO nic) {
+ if (Networks.BroadcastDomainType.getSchemeValue(nic.getBroadcastUri())
== Networks.BroadcastDomainType.Vxlan) {
+ // VXLAN bridges are named after the VNI alone, so no physical
interface lookup is needed
+ String vxlanId =
Networks.BroadcastDomainType.getValue(nic.getBroadcastUri());
+ if (vxlanId != null) {
+ deleteVnetBr(generateVxnetBrName(null, vxlanId), true);
Review Comment:
since the pif is null here, deleteVnetBr ends up passing "vx" (parsed from
brvx-5000) as -p to modifyvxlan.sh, so the multicast route del runs against dev
vx. doesnt that leave the multicast route on the real interface behind after
delete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
