sudo87 commented on code in PR #13325:
URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4119421758
##########
server/src/main/java/com/cloud/api/query/dao/VpcOfferingJoinDaoImpl.java:
##########
@@ -78,6 +78,8 @@ public VpcOfferingResponse newVpcOfferingResponse(VpcOffering
offering) {
offeringResponse.setSpecifyAsNumber(offering.isSpecifyAsNumber());
}
offeringResponse.setConserveMode(offering.isConserveMode());
+ Integer pubNetworkRate = offering.getPublicNetworkRate();
+ offeringResponse.setPublicNetworkRate((pubNetworkRate == null ||
pubNetworkRate <= 0 ) ? -1 : pubNetworkRate);
Review Comment:
API response should be consistent; -1 represents unlimited rate. Internally
null/absence/0/-1 mean unlimited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
