DaanHoogland commented on code in PR #14049:
URL: https://github.com/apache/cloudstack/pull/14049#discussion_r3940362018
##########
api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java:
##########
@@ -76,7 +76,7 @@ public boolean equals(Object other) {
@Override
public int hashCode() {
- return key.hashCode();
+ return key == null ? 0 : key.hashCode();
}
Review Comment:
I’m all for hardening @nagaboinaramgopal , just that I am against too much
code and I wonder if this class really needs hashCode()/equals() methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
