DaanHoogland commented on code in PR #14049:
URL: https://github.com/apache/cloudstack/pull/14049#discussion_r3932723070
##########
api/src/main/java/org/apache/cloudstack/api/response/TemplateOVFPropertyResponse.java:
##########
@@ -76,7 +76,7 @@ public boolean equals(Object other) {
@Override
public int hashCode() {
- return key.hashCode();
+ return key == null ? 0 : key.hashCode();
}
Review Comment:
I don’t know why this method is implemented, but I am pretty sure a hashcode
of only the key and none of the other fields/attributes is not a valid
implementation. Did you encouter and error that made you implement this
@nagaboinaramgopal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
