shwstppr commented on code in PR #11976:
URL: https://github.com/apache/cloudstack/pull/11976#discussion_r3568640673


##########
server/src/main/java/com/cloud/api/ApiServer.java:
##########
@@ -348,6 +348,19 @@ public class ApiServer extends ManagerBase implements 
HttpRequestHandler, ApiSer
             , ConfigKey.Scope.Global, null, null, null, null, null, 
ConfigKey.Kind.Select,
             
EnumSet.allOf(ApiSessionKeyCheckOption.class).stream().map(Enum::toString).collect(Collectors.joining(",
 ")));
 
+    public static final ConfigKey<Boolean> ApiDisallowInternalIds = new 
ConfigKey<>(
+            ConfigKey.CATEGORY_ADVANCED,
+            Boolean.class,
+            "api.disallow.internal.ids",
+            "true",
+            "When enabled, APIs will not honour requests containing internal 
database IDs. "
+                    + "Only UUIDs will be accepted as entity identifiers. "
+                    + "By default, internal IDs are still accepted for 
backward compatibility with pre-3.x APIs.",

Review Comment:
   ```suggestion
                       + "By default, internal IDs are not accepted even for 
pre-3.x APIs.",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to