Copilot commented on code in PR #13424:
URL: https://github.com/apache/cloudstack/pull/13424#discussion_r3438610448
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -196,10 +196,12 @@ backup_running_vm() {
# Print statistics
virsh -c qemu:///system domjobinfo $VM --completed
- du -sb $dest | cut -f1
-
- umount $mount_point
- rmdir $mount_point
+ backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true
+
+ timeout 60 umount "$mount_point" 2>/dev/null || true
+ rmdir "$mount_point" 2>/dev/null || true
+
Review Comment:
If `du` fails here, `backup_size` becomes empty and `echo -n "$backup_size"`
emits nothing. The KVM agent code parses the last output line as a number for
running-VM backups (see `LibvirtTakeBackupCommandWrapper`), so an empty/missing
size will cause a `NumberFormatException` and still fail the backup job. Also,
`umount`/`rmdir` failures are fully suppressed; consider at least logging them
so mount leaks are diagnosable without failing the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
