daviftorres commented on PR #13424:
URL: https://github.com/apache/cloudstack/pull/13424#issuecomment-4731183231

   ## Proposed Changes Rationale
   
   ```bash
   backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true
   ```
   - NFS issues may cause `du` command to fail.
   - **A size retrieval failure should not invalidate a successful backup.**
   
   ```bash
   timeout 60 umount "$mount_point" 2>/dev/null || true
   rmdir "$mount_point" 2>/dev/null || true
   ```
   - Another process may keep the device busy (e.g., parallel backups).
   - Network issues may cause hangs on NFS.
   - **Cleanup failures should not invalidate a successful backup.**
   
   ```bash
   echo "$backup_size"
   ```
   - Outputs the size at the end to confirm the script completed past the 
potentially problematic commands.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to