Copilot commented on code in PR #13240:
URL: https://github.com/apache/cloudstack/pull/13240#discussion_r3304426063


##########
ui/public/locales/en.json:
##########
@@ -2192,7 +2193,7 @@
 "label.router.health.check.success": "Success",
 "label.router.health.checks": "Health checks",
 "label.routercount": "Total of virtual routers",
-"label.routerip": "IPv4 address for the VR in this Network.",
+"label.routerip": "Public IPv4 address for the VR",
 "label.routeripv6": "IPv6 address for the VR in this Network.",

Review Comment:
   `label.routerip`’s meaning is being changed (now “Public IPv4 address for 
the VR”), but several non-English locale files already define `label.routerip` 
with the old shared-network meaning (e.g. el_GR/ja_JP/ko_KR/pt_BR/zh_CN). Since 
the UI uses `label.routerip` for the Source NAT/public VR address in isolated 
network/VPC creation, those locales will now show misleading text unless their 
`label.routerip` translations are updated (or a new key is introduced and used 
instead).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to