weizhouapache commented on code in PR #13240:
URL: https://github.com/apache/cloudstack/pull/13240#discussion_r3302072948
##########
ui/public/locales/en.json:
##########
@@ -2193,7 +2193,7 @@
"label.router.health.check.success": "Success",
"label.router.health.checks": "Health checks",
"label.routercount": "Total of virtual routers",
-"label.routerip": "IPv4 address for the VR in this Network.",
+"label.routerip": "Public IPv4 address for the VR",
Review Comment:
actually `routerip` is the ip address of VR on the guest network, not on
Public network
##########
ui/src/views/network/CreateSharedNetworkForm.vue:
##########
@@ -344,7 +344,7 @@
</a-row>
<a-form-item v-if="isVirtualRouterForAtLeastOneService"
name="routerip" ref="routerip">
<template #label>
- <tooltip-label :title="$t('label.routerip')"
:tooltip="apiParams.routerip.description"/>
+ <tooltip-label :title="$t('label.sharedrouterip')"
:tooltip="apiParams.routerip.description"/>
Review Comment:
good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
