bernardodemarco commented on code in PR #12975:
URL: https://github.com/apache/cloudstack/pull/12975#discussion_r3150231904
##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -111,6 +111,10 @@ public interface UserVmManager extends UserVmService {
ConfigKey<Boolean> AllowDifferentHostTagsOfferingsForVmScale = new
ConfigKey<>("Advanced", Boolean.class,
"allow.different.host.tags.offerings.for.vm.scale", "false",
"Enables/Disable allowing to change a VM offering to offerings
with different host tags", true);
+ ConfigKey<Boolean> AutoMigrateVmOnLiveScaleInsufficientCapacity = new
ConfigKey<>("Advanced", Boolean.class,
"auto.migrate.vm.on.live.scale.insufficient.capacity",
Review Comment:
Yes, it could. However, if it were a parameter, since end users should not
have any control over the cloud infrastructure, it would preferably not be
available for them. And, to maintain behavior compatibility, the parameter's
default value would need to be `true`, meaning that, for end users, VMs would
always be auto migrated on insufficient capacity scenarios, which is not
interesting at all.
@hsato03, so, these are the main reasons why a new setting was chosen
instead of a new parameter. Does this sound fine to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
