hsato03 commented on code in PR #12975:
URL: https://github.com/apache/cloudstack/pull/12975#discussion_r3143633650
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -455,6 +456,8 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
private static final int MINIMUM_QEMU_VERSION_FOR_INCREMENTAL_SNAPSHOT =
6001000;
+ public static final long MAX_CPU_QUOTA = 17592186044415L;
Review Comment:
I think this constant fits better in the `CpuTuneDef` class.
##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -111,6 +111,10 @@ public interface UserVmManager extends UserVmService {
ConfigKey<Boolean> AllowDifferentHostTagsOfferingsForVmScale = new
ConfigKey<>("Advanced", Boolean.class,
"allow.different.host.tags.offerings.for.vm.scale", "false",
"Enables/Disable allowing to change a VM offering to offerings
with different host tags", true);
+ ConfigKey<Boolean> AutoMigrateVmOnLiveScaleInsufficientCapacity = new
ConfigKey<>("Advanced", Boolean.class,
"auto.migrate.vm.on.live.scale.insufficient.capacity",
Review Comment:
This new setting could be converted into a parameter of the
`scaleVirtualMachine` API (like the existing `automigrate` parameter).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
