harikrishna-patnala commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3057249150
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -821,6 +824,26 @@ protected AgentAttache notifyMonitorsOfConnection(final
AgentAttache attache, fi
host.getDetails().put(Host.HOST_OVFTOOL_VERSION,
ovftoolVersion);
updateNeeded = true;
}
+ if (StringUtils.isNotBlank(vddkSupport) &&
!vddkSupport.equals(host.getDetails().get(Host.HOST_VDDK_SUPPORT))) {
+ host.getDetails().put(Host.HOST_VDDK_SUPPORT,
vddkSupport);
+ updateNeeded = true;
+ }
+ if
(!StringUtils.defaultString(vddkLibDir).equals(StringUtils.defaultString(host.getDetails().get(Host.HOST_VDDK_LIB_DIR))))
{
+ if (StringUtils.isBlank(vddkLibDir)) {
+ host.getDetails().remove(Host.HOST_VDDK_LIB_DIR);
+ } else {
+ host.getDetails().put(Host.HOST_VDDK_LIB_DIR,
vddkLibDir);
+ }
+ updateNeeded = true;
+ }
+ if
(!StringUtils.defaultString(vddkVersion).equals(StringUtils.defaultString(host.getDetails().get(Host.HOST_VDDK_VERSION))))
{
+ if (StringUtils.isBlank(vddkVersion)) {
+ host.getDetails().remove(Host.HOST_VDDK_VERSION);
+ } else {
+ host.getDetails().put(Host.HOST_VDDK_VERSION,
vddkVersion);
+ }
+ updateNeeded = true;
Review Comment:
Version identification is not just enough to claim the support but we will
also need the directory where it is located as we need to pass that in the
virt-v2v command with vddk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
