Re: [PR] test_accounts.py failure fix - keep the camelCase parameter name "domainId" [cloudstack]

[via GitHub]

sureshanaparti commented on PR #12689:
URL: https://github.com/apache/cloudstack/pull/12689#issuecomment-3957057257

   > > > > I feel we should either fix the caller or adopt a generic approach 
for all params.
   > > > 
   > > > 
   > > > the parameter convention is all lowercase.
   > > 
   > > 
   > > OauthLogin and Login APIs expect domainId in camelCase 
https://cloudstack.apache.org/api/apidocs-4.20/apis/oauthlogin.html 
https://cloudstack.apache.org/api/apidocs-4.6/user/login.html
   > > <img alt="Screenshot 2026-02-24 at 2 59 28 PM" width="824" height="47" 
src="https://private-user-images.githubusercontent.com/63767682/554036499-bfe86615-c3d2-44e0-bb51-7388df8cdfaa.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzE5NTgwMjYsIm5iZiI6MTc3MTk1NzcyNiwicGF0aCI6Ii82Mzc2NzY4Mi81NTQwMzY0OTktYmZlODY2MTUtYzNkMi00NGUwLWJiNTEtNzM4OGRmOGNkZmFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjI0VDE4Mjg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlYTFiMDVhZjUzMDdhZDczNGEzYzcyNjZjNTk4ZmM0ZmRhNDlmMDAzMTgyYzQxMjRhOGNlYWE0NWU2NzJjZmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WW4-EEU9eSq_KziiE8ArVAlyUoXMocjyoXCw2QTtApg";>
   > > We would need to deprecate the parameter in these APIs.
   > 
   > Sorry this wasn't clear from the PR title/description
   
   @shwstppr @abh1sar I've removed the camelCase parameter in this PR: 
https://github.com/apache/cloudstack/pull/12585, resulting in test failure, so 
fixed it for the test. We can address using a generic approach (all lowercase) 
and deprecate the camelCase parameters (wherever used) in a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org