Re: [PR] Update backup framework enabled config to global scope [cloudstack]

[via GitHub]

weizhouapache commented on PR #11567:
URL: https://github.com/apache/cloudstack/pull/11567#issuecomment-3833471355

   > > > > should it be "Disable" instead of "Enable" ?
   > > > 
   > > > 
   > > > Default is disabled, so "Enable" here is right.
   > > 
   > > 
   > > it looks different as what is described <img alt="image" width="1631" 
height="357" 
src="https://private-user-images.githubusercontent.com/57355700/543626697-e76386ae-87a6-4853-a97b-f55051ec1b45.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAwMTcxMjcsIm5iZiI6MTc3MDAxNjgyNywicGF0aCI6Ii81NzM1NTcwMC81NDM2MjY2OTctZTc2Mzg2YWUtODdhNi00ODUzLWE5N2ItZjU1MDUxZWMxYjQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAyMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMjAyVDA3MjAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDQ0YmVmNTc4ZWU3ZDljYzVlYzI5MDNlMGJkZjBmN2E4MmE5ZDJjZTdjMjQ2N2FkZjQyMGFiZDc3YjlmMmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KN411vCI78JYCzSl_eUrQTPUOVGqhngcD7oFpLiuSsU";>
   > 
   > @weizhouapache this is earlier description, maybe I didn't confirm my last 
update, so it's not saved. check now. thanks.
   
   ok, thanks @sureshanaparti 
   
   @abh1sar 's testing results look ok
   
   some questions
   1. since the setting is now gloabl, is there a way to determine if the 
backup is enabled for the zone, for example, by backup provider ?
   2. if not needed, can you remove some validation steps in the soure code ?
   3. on the UI, is there a way to disable or hide the icons for backup for vms 
in the zone without backup support ? sounds like a UI improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org