Pearl1594 commented on code in PR #11210:
URL: https://github.com/apache/cloudstack/pull/11210#discussion_r2213476628
##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1178,7 +1175,7 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
buf.append("
vmpassword=").append(_configDao.getValue("system.vm.password"));
}
- if (NTPServerConfig.value() != null) {
+ if (!StringUtils.isEmpty(NTPServerConfig.value())) {
Review Comment:
I have used the same logic in
[COnsoleProxyManagerImpl](https://github.com/apache/cloudstack/pull/11210/files#diff-83d8d4dd27757aa0ff1364c3d156e2396e79f043073acffdddfeb37b1790a8c7R1279).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
