weizhouapache commented on code in PR #11210:
URL: https://github.com/apache/cloudstack/pull/11210#discussion_r2211952141
##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1178,7 +1175,7 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
buf.append("
vmpassword=").append(_configDao.getValue("system.vm.password"));
}
- if (NTPServerConfig.value() != null) {
+ if (!StringUtils.isEmpty(NTPServerConfig.value())) {
Review Comment:
May use the same code for CPVM
##########
engine/api/src/main/java/com/cloud/vm/VirtualMachineGuru.java:
##########
@@ -37,6 +38,9 @@
*/
public interface VirtualMachineGuru {
+ static final ConfigKey<String> NTPServerConfig = new
ConfigKey<String>(String.class, "ntp.server.list", "Advanced", null,
+ "Comma separated list of NTP servers to configure in Secondary
storage VM", true, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
Review Comment:
Description can be updated to "System VMs"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
