nvazquez commented on code in PR #11198:
URL: https://github.com/apache/cloudstack/pull/11198#discussion_r2213474332


##########
plugins/storage/image/default/src/main/java/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java:
##########
@@ -74,7 +76,14 @@ private String createObjectNameForExtractUrl(String 
installPath, ImageFormat for
         }
 
         if (format != null) {
-            objectNameInUrl = objectNameInUrl + "." + 
format.getFileExtension();
+            if (dataObject.getTO() != null
+                    && 
DataObjectType.VOLUME.equals(dataObject.getTO().getObjectType())
+                    && 
HypervisorType.KVM.equals(dataObject.getTO().getHypervisorType())) {
+                // Fix: The format of KVM volumes on image store is qcow2
+                objectNameInUrl = objectNameInUrl + "." + 
ImageFormat.QCOW2.getFileExtension();

Review Comment:
   Sorry @weizhouapache please discard, I thought the copy for the download 
will be stored on that table, but that table doesn't have the format column, 
should be using the format from volumes table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to