bernardodemarco commented on code in PR #11179:
URL: https://github.com/apache/cloudstack/pull/11179#discussion_r2208775410
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -4490,7 +4493,7 @@ private Pair<List<TemplateJoinVO>, Integer>
searchForTemplatesInternal(Long temp
boolean showDomr, boolean onlyReady, List<Account>
permittedAccounts, Account caller,
ListProjectResourcesCriteria listProjectResourcesCriteria,
Map<String, String> tags,
boolean showRemovedTmpl, List<Long> ids, Long parentTemplateId,
Boolean showUnique, String templateType,
- Boolean isVnf) {
+ Boolean isVnf, Long domainId, boolean isRecursive) {
Review Comment:
@DaanHoogland yes, I agree.
IMHO, the overall workflows of the `listIsos` and `listTemplates` APIs could
really benefit from refactoring. There's extensive DAO manipulation within the
business/service layer, a lack of modularization, and the current structure
makes troubleshooting and maintenance difficult.
I'll open a separate issue to address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
