DaanHoogland commented on code in PR #11179:
URL: https://github.com/apache/cloudstack/pull/11179#discussion_r2202539352
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -4490,7 +4493,7 @@ private Pair<List<TemplateJoinVO>, Integer>
searchForTemplatesInternal(Long temp
boolean showDomr, boolean onlyReady, List<Account>
permittedAccounts, Account caller,
ListProjectResourcesCriteria listProjectResourcesCriteria,
Map<String, String> tags,
boolean showRemovedTmpl, List<Long> ids, Long parentTemplateId,
Boolean showUnique, String templateType,
- Boolean isVnf) {
+ Boolean isVnf, Long domainId, boolean isRecursive) {
Review Comment:
I am not a fan of extending parameter lists beyond three. It already was,
but we should think about passing the command or an interface the command
adheres to instead. Not necessarily in this PR but keep in mind this is a
maintainability issue. a lot of these are directly retrieved from the cmd
object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
