DaanHoogland commented on code in PR #10740:
URL: https://github.com/apache/cloudstack/pull/10740#discussion_r2197692921
##########
api/src/main/java/org/apache/cloudstack/api/response/StoragePoolResponse.java:
##########
@@ -77,19 +77,24 @@ public class StoragePoolResponse extends
BaseResponseWithAnnotations {
@Param(description = "the name of the cluster for the storage pool")
private String clusterName;
+ @SerializedName(ApiConstants.CAPACITY_BYTES)
+ @Param(description = "bytes CloudStack can provision from this storage
pool", since = "4.19.3")
+ private Long capacityBytes;
+
+ @Deprecated(since = "4.19.3")
Review Comment:
```suggestion
@Deprecated(since = "4.19.4")
```
##########
api/src/main/java/org/apache/cloudstack/api/response/StoragePoolResponse.java:
##########
@@ -77,19 +77,24 @@ public class StoragePoolResponse extends
BaseResponseWithAnnotations {
@Param(description = "the name of the cluster for the storage pool")
private String clusterName;
+ @SerializedName(ApiConstants.CAPACITY_BYTES)
+ @Param(description = "bytes CloudStack can provision from this storage
pool", since = "4.19.3")
Review Comment:
```suggestion
@Param(description = "bytes CloudStack can provision from this storage
pool", since = "4.19.4")
```
##########
api/src/main/java/org/apache/cloudstack/api/response/StoragePoolResponse.java:
##########
@@ -145,6 +150,10 @@ public class StoragePoolResponse extends
BaseResponseWithAnnotations {
@Param(description = "whether this pool is managed or not")
private Boolean managed;
+ @SerializedName(ApiConstants.DETAILS)
+ @Param(description = "additional key/value details of the storage pool",
since = "4.19.3")
Review Comment:
```suggestion
@Param(description = "additional key/value details of the storage pool",
since = "4.19.4")
```
##########
engine/schema/src/main/resources/META-INF/db/schema-41920to41930-cleanup.sql:
##########
Review Comment:
rename file
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41920to41930.java:
##########
Review Comment:
reconsidder in which version this is added and rename the file.
##########
engine/schema/src/main/resources/META-INF/db/schema-41920to41930.sql:
##########
Review Comment:
rename file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
