sureshanaparti commented on code in PR #11113:
URL: https://github.com/apache/cloudstack/pull/11113#discussion_r2183135519


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtSetupDirectDownloadCertificateCommandWrapper.java:
##########
@@ -86,7 +86,7 @@ private String getKeyStoreFilePath(File agentFile) {
     private void importCertificate(String tempCerFilePath, String 
keyStoreFile, String certificateName, String privatePassword) {
         s_logger.debug("Importing certificate from temporary file to 
keystore");
         String keyToolPath = Script.getExecutableAbsolutePath("keytool");
-        int result = Script.executeCommandForExitValue(keyToolPath, 
"-importcert", "file", tempCerFilePath,
+        int result = Script.executeCommandForExitValue(keyToolPath, 
"-importcert", "-file", tempCerFilePath,

Review Comment:
   @weizhouapache is the file option updated for other distros as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to