DaanHoogland commented on code in PR #10506:
URL: https://github.com/apache/cloudstack/pull/10506#discussion_r1991057339
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java:
##########
@@ -55,15 +56,18 @@ public class QuotaStatementCmd extends BaseCmd {
ApiConstants.PARAMETER_DESCRIPTION_START_DATE_POSSIBLE_FORMATS)
private Date startDate;
- @Parameter(name = ApiConstants.TYPE, type = CommandType.INTEGER,
description = "List quota usage records for the specified usage type")
+ @Parameter(name = ApiConstants.TYPE, type = CommandType.INTEGER,
description = "List quota usage records for the specified usage type.")
private Integer usageType;
@ACL
@Parameter(name = ApiConstants.ACCOUNT_ID, type = CommandType.UUID,
entityType = AccountResponse.class, description = "List usage records for the
specified account")
private Long accountId;
+ @Parameter(name = ApiConstants.SHOW_RESOURCES, type = CommandType.BOOLEAN,
description = "List the resources of each quota type in the period.")
+ private boolean showResources;
+
@Inject
- private QuotaResponseBuilder _responseBuilder;
+ protected QuotaResponseBuilder responseBuilder;
Review Comment:
default scope seems more apropriate for injected objects, Why is it
protected?
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java:
##########
@@ -107,6 +120,8 @@
import com.cloud.user.dao.UserDao;
import com.cloud.utils.Pair;
import com.cloud.utils.db.Filter;
+import com.cloud.vm.VMInstanceVO;
+import com.cloud.vm.dao.VMInstanceDao;
Review Comment:
there is a block of `com.cloud` above as well, starting at line 44. Can you
unify the two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
